nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1109: libs/libnx/nxfonts/.gitignore: Ignore auto-generated file.
Date Sat, 23 May 2020 17:24:19 GMT

xiaoxiang781216 commented on a change in pull request #1109:
URL: https://github.com/apache/incubator-nuttx/pull/1109#discussion_r429563424



##########
File path: libs/libnx/nxfonts/.gitignore
##########
@@ -1,2 +1,3 @@
 nxfonts_convert_*bpp.c
 nxfonts_bitmaps_*.c
+nxfonts_tom-thumb-4x6.c

Review comment:
       Don't need since the generated name change to nxfonts_bitmaps_tom-thumb-4x6.c by commit:
   ```
   commit 23389215bb09b2997c2e29a39b635339c202bf3e
   Author: liuhaitao <liuhaitao@xiaomi.com>
   Date:   Tue Apr 28 14:18:22 2020 +0800
   
       libnx/nxfonts: change the generated file nxfonts_tom-thumb-4x6.c to nxfonts_bitmap_tom-thumb-4x6.c
       
       Align the generated files name, so make distclean could also remove all nxfonts_bitmaps_*.c
files, no
       need to add one more extra DELFILE for nxfonts_tom-thumb-4x6.c.
       
       Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
   ```
   But forget to update .gitignore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message