nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #250: Update make dependency for elf/module/nxflat/posix_spawn/sotest/thttpd
Date Thu, 21 May 2020 05:44:32 GMT

xiaoxiang781216 commented on a change in pull request #250:
URL: https://github.com/apache/incubator-nuttx-apps/pull/250#discussion_r428456387



##########
File path: Application.mk
##########
@@ -219,7 +219,7 @@ else
 context::
 endif
 
-.depend: Makefile $(SRCS)
+.depend: Makefile $(wildcard $(SRCS))

Review comment:
       Yes, we have to remove the generated source from Make.dep. The build sequence is:
   1.context
   2.depend
   3.compile
   The code generated dynamically need the result from phase 3(compile), but phase 2(depend)
need all source code ready. This is a chicken and egg problem. We decide to not generate the
dependence for the dynamically code since the dependence relationship is optinal, but the
compile is critical.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message