nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on pull request #1079: nxstyle: Fix distinction be source and header file for long lines.
Date Tue, 19 May 2020 23:40:52 GMT

patacongo commented on pull request #1079:
URL: https://github.com/apache/incubator-nuttx/pull/1079#issuecomment-631144775


   > The reason was this:
   > 
   > In past conversation you had told me that readability was more important than line
length and that long lines were OK in arch headers. The code base reflected that.
   
   I have no recollection of that in the past.  But we cut a lot of corners in the past that
we no longer do.
   
   > It is sad to me that the code has become less readable and information has been removed
to accommodate the line length. I took pride in following your tradition of reflecting the
datasheets in the headers.
   
   This I disagree with 1000%.  The headers should not duplicate all of the information in
the datasheets.  That is just wrong.  Comments should simply identify the field.  Look in
the data sheet if you want a long detailed description.  Don't force it to the right side
of a #define.  That is hideous.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message