nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1072: Update make dependency to enable configure.sh stage with parallel build
Date Tue, 19 May 2020 18:22:27 GMT

Ouss4 commented on a change in pull request #1072:
URL: https://github.com/apache/incubator-nuttx/pull/1072#discussion_r427508919



##########
File path: tools/Makefile.unix
##########
@@ -506,42 +506,28 @@ pass2dep: context tools/mkdeps$(HOSTEXEEXT) tools/cnvwindeps$(HOSTEXEEXT)
 # location: https://bitbucket.org/nuttx/tools/downloads/.  See README.txt
 # file in the NuttX tools GIT repository for additional information.
 
-do_config: dirlinks apps_preconfig
+config: apps_preconfig
 	$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf Kconfig
 
-config: do_config clean_context
-
-do_oldconfig: dirlinks apps_preconfig
+oldconfig: apps_preconfig
 	$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --oldconfig Kconfig
 
-oldconfig: do_oldconfig clean_context
-
-do_olddefconfig: dirlinks apps_preconfig
+olddefconfig: apps_preconfig
 	$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig
 
-olddefconfig: do_olddefconfig clean_context
-
-do_menuconfig: dirlinks apps_preconfig
+menuconfig: apps_preconfig
 	$(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-mconf Kconfig
 
-menuconfig: do_menuconfig clean_context

Review comment:
       In apps `clean_context` deletes *.pdat and *.bdat files.  When removing an app through
menuconfig for example, without `clean_context` the app won't be removed. 
   And a `make` after a `clean` would fail with an undefined reference, since the `built_list/proto.h`
are removed (by `clean`) then repopulated (during `depend`) with all the *.pdat and *.bdat
file.
   Is removing `clean_context` necessary in a parallel build scenario?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message