nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] hartmannathan commented on pull request #1051: [DO NOT MERGE] Add support for STM32G474 family
Date Mon, 18 May 2020 16:23:17 GMT

hartmannathan commented on pull request #1051:
URL: https://github.com/apache/incubator-nuttx/pull/1051#issuecomment-630293084


   > > When I finish making all the changes you requested, will it be easier for you
if I squash the commits? Or leave them separate?
   > 
   > @hartmannathan - you can use [mv-changes](https://github.com/MikhailGolubtsov/git-mv-changes)
to regroup by subject (i.e. pinmap, adc) or squash by file.
   
   @davids5 -- ok... I'll wait until you and @raiden00pl tell me that you're ready, because
rearranging commits will make it harder to see which change is related to which comment above...
   
   Meanwhile I found and fixed some other issues, like filling in the missing ADC EXTSEL/JEXTSEL
defines.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message