nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] jlaitine commented on pull request #1042: stm32h7 progmem fixes
Date Mon, 18 May 2020 05:31:49 GMT

jlaitine commented on pull request #1042:
URL: https://github.com/apache/incubator-nuttx/pull/1042#issuecomment-629955048


   > My time is limited and the OP suggested:
   > 
   > > maybe we need to study this one more and come back to this PR later
   > 
   > @patacongo I wanted to see if the the [unresolved](https://github.com/apache/incubator-nuttx/pull/1042#pullrequestreview-411654654)
would be resolved.
   > 
   > I have some H7 work on my bench this week, so if you could refrain form just merging,
it would be appreciated.
   
   There is no harm done; as I said the previous version didn't really work much at all, and
this one has been thoroughly tested with many different configurations. That "if" may be redundant,
but doesn't harm anything; we can just remove it later if it is found useless.
   
   Regarding the process, IMHO the PR should not be approved if it is not intended to be merged
yet. I have seen many processes using PRs, and have myself liked the best the way where submitter
merges the PR himself, after the maintainer(s) have approved it. This way the PR submitter
takes more mental responsibility of his submission, but the decision/approval is still with
the maintainer.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message