nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #1010: tools/refresh.sh --help
Date Mon, 11 May 2020 06:03:24 GMT

xiaoxiang781216 edited a comment on issue #1010:
URL: https://github.com/apache/incubator-nuttx/issues/1010#issuecomment-626486567


   > > > So if no logical content of the defconfig has changed then it will not be
updated. That means if the ordering of elements changes so that there is a lexical content
changes, it will not be updated and the user will not be prompted.
   > > 
   > > 
   > > But I think the root cause is that cmpconfig ignore the order difference. We
should replace with diff command instead.
   > 
   > The use case where I experienced this was as follows:
   > 
   > 1. I use find and sed to modify a configuration setting name.  This is a dangerous
practice because it can create an invalid configuration.
   > 2. I use refresh.sh to fix this:  It will create a valid defconfig and, if the change
was innocuous, it will not show any differences.  However, it may result in a re-ordering
of defconfig setting, putting them back in alphabetic order.
   > 3. In either case, you would like to see what is different and be able to save the
updated defconfig with the configs in the correct order.  The old version of refresh.sh used
tools/compconfig and it might show no differences in this case.  However, it still allowed
the opportunity to save the defconfig file, even if there were no differences.
   
   Yes, the real difference is that the order change will show to the end user now. The behaviour
change is minor, but simplify how we implment the github action because we want to trigger
the error if any difference(even just the order) exist.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message