nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on pull request #1022: Rename clock_systime[r|spec] to clock_systime_[ticks|timespec]
Date Sun, 10 May 2020 19:34:26 GMT

patacongo commented on pull request #1022:
URL: https://github.com/apache/incubator-nuttx/pull/1022#issuecomment-626378174


   No, I was mistaken.  You did modify the tests.  Your PR removes the parentheses and introduces
the errors.  You need to back out all of the changes like:
   
       @@ -485,7 +487,7 @@ SINT_T sddep_write(void *src, void *dst, UI_32 size, SINT_T type,
               lc823450_dmasetup(_hwdma[ch],
               lc823450_dmasetup(_hwdma[ch],
                                 LC823450_DMA_SRCWIDTH_WORD |
                                 LC823450_DMA_SRCWIDTH_WORD |
                                 LC823450_DMA_DSTWIDTH_WORD |
                                 LC823450_DMA_DSTWIDTH_WORD |
           -                     (type == SDDR_RW_INC_WORD ? LC823450_DMA_SRCINC : 0),
           +                     type == SDDR_RW_INC_WORD ? LC823450_DMA_SRCINC : 0,
                                 (uint32_t)src, (uint32_t)dst, size / 4);
                                 (uint32_t)src, (uint32_t)dst, size / 4);
               break;
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message