nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on pull request #1017: include/nuttx/sched.h: Make naming of all internal names consistent
Date Sat, 09 May 2020 17:36:53 GMT

patacongo commented on pull request #1017:
URL: https://github.com/apache/incubator-nuttx/pull/1017#issuecomment-626210686


   Note:  This depends on apps PR 244:
   
   - The internal interfaces were renamed.  The internal interfaces must not be used by applications.
 They should not be referenced in ANY apps.
   
   - But they are.  apps/netutils/thttpd callS sched_foreach().  It should not, that is the
first error.  But I am not fixing that one today.
   
   - sched_foreach() has been renamed nxsched_foreach() -- that is correct since it is an
internal OS function not for use by applications.
   
   - But now apps/netutils/thttpd won't compile unless I change the name to nxsched_foreach.
   
   - PR 244 should now pass the PR checks because this PR was merged.
   
   - But for now, all other PR checks are broken until apps PR 244 is merged
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message