nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1009: Add support for preemptive scheduling in simulator build
Date Sat, 09 May 2020 13:51:05 GMT

xiaoxiang781216 commented on a change in pull request #1009:
URL: https://github.com/apache/incubator-nuttx/pull/1009#discussion_r422498303



##########
File path: arch/sim/src/sim/up_idle.c
##########
@@ -89,6 +89,15 @@ void up_idle(void)
     }
 #endif
 
+#ifndef CONFIG_SIM_PREEMPTIBLE
+  /* If the system is idle, then process "fake" timer interrupts.
+   * Hopefully, something will wake up.
+   */
+
+  nxsched_process_timer();

Review comment:
       > We no longer needed the fake timer interrupts delivered from `Idle Task` because
we can rely on the host timer to drive the scheduler. What do you think ?
   
   But we can reuse the most logic inside up_oneshot.c, add the alarm tmer logic and empty
up_timer_update.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message