nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] v01d commented on pull request #1006: Move stm32 common board logic to stm32/common/
Date Fri, 08 May 2020 19:47:09 GMT

v01d commented on pull request #1006:
URL: https://github.com/apache/incubator-nuttx/pull/1006#issuecomment-625987360


   I've just moved several other device handling logic into the common folder. I'm moving
slowly, it is a big task. For now ignore style errors, since I'm actually having to fix old
non compliant files in the process. 
   Please review these new cases as some where not as trivial as the others.
   
   I think many could be even be moved into a higher common point since they could actually
be applicable to other stm32 variants, but that is left for future work. 
   I also think that it would be useful to be able to configure some things via menuconfig
(such as I2C/SPI port) for a sensor, which boards usually hardcode. Maybe the common/ dir
could expose this via a Kconfig and boards could optionally choose to fix it via own Kconfig
entry for board-mounted sensors where the port assignation is fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message