nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #996: sched/init/nx_start.c: Reinstate logic to remove compiler warning
Date Thu, 07 May 2020 19:43:18 GMT

xiaoxiang781216 commented on a change in pull request #996:
URL: https://github.com/apache/incubator-nuttx/pull/996#discussion_r421749510



##########
File path: sched/init/nx_start.c
##########
@@ -545,6 +545,8 @@ void nx_start(void)
 
   nxsem_initialize();
 
+#if defined(MM_KERNEL_USRHEAP_INIT) || defined(CONFIG_MM_KERNEL_HEAP) || \
+    defined(CONFIG_MM_PGALLOC)

Review comment:
       it's better to use #error to stop the compiling in the wrong case




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message