nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #987: Implement the up_tls_info for the rest of the architectures
Date Thu, 07 May 2020 02:55:58 GMT

patacongo commented on a change in pull request #987:

File path: arch/arm/include/tls.h
@@ -37,12 +37,12 @@
- * Name: up_getsp
+ * Name: arm_getsp

Review comment:
       > Maybe I can do something similar as RISC-V for instance and take the arm_getsp
to the arch.h file.
   Don't bother.  It would still be exported to all files and should still require the up_
prefix.  There is no way to avoid avoid that.  TLS requires that that function be used outside
of the ARM code.  Same is true for all of the other architectures.
   I don't recommend changing the name, but not for that reason.  I don't recommend changing
the name because it is not a documented, controlled interface.  It is a private private for
use within the tls.h header file.   it does not have a consistent protoype, it is not prototyped
in include/nuttx/arch.h so it doesn't matter what you call it.
   up_ would be more architecturually correct probably, but it is not important.  All MCU
names used outide of the architecutre-/board-specific logic should be called up_

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message