nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #987: Implement the up_tls_info for the rest of the architectures
Date Wed, 06 May 2020 23:36:37 GMT

patacongo commented on a change in pull request #987:
URL: https://github.com/apache/incubator-nuttx/pull/987#discussion_r421152756



##########
File path: arch/arm/include/tls.h
##########
@@ -37,12 +37,12 @@
  ****************************************************************************/
 
 /****************************************************************************
- * Name: up_getsp
+ * Name: arm_getsp

Review comment:
       Actually, in this case, up_getsp() is the correct name since it is a common interface
that is exported outside of the ARM architecture.  Same is true of other locations.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message