nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #977: Implements TLS for unaligned stacks.
Date Tue, 05 May 2020 18:47:39 GMT

patacongo commented on a change in pull request #977:
URL: https://github.com/apache/incubator-nuttx/pull/977#discussion_r420330577



##########
File path: arch/arm/include/tls.h
##########
@@ -97,11 +82,15 @@ static inline uint32_t up_getsp(void)
  *
  ****************************************************************************/
 
+#ifdef CONFIG_TLS_ALIGNED
 static inline FAR struct tls_info_s *up_tls_info(void)
 {
   DEBUGASSERT(!up_interrupt_context());
   return TLS_INFO((uintptr_t)up_getsp());

Review comment:
       I think it is good to keep the architecture-specific hook to handle any future differences
we encounter.  There is no benefit to removing it.  There is benefit to keeping it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message