nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #965: fs: Remove all LIBC_IOCTL_VARIADIC related stuff
Date Tue, 05 May 2020 15:10:12 GMT

patacongo commented on a change in pull request #965:
URL: https://github.com/apache/incubator-nuttx/pull/965#discussion_r420185363



##########
File path: syscall/syscall.csv
##########
@@ -42,7 +41,7 @@
 "if_indextoname","net/if.h","defined(CONFIG_NETDEV_IFINDEX)","FAR char *","unsigned int","FAR
char *"
 "if_nametoindex","net/if.h","defined(CONFIG_NETDEV_IFINDEX)","unsigned int","FAR const char
*"
 "insmod","nuttx/module.h","defined(CONFIG_MODULE)","FAR void *","FAR const char *","FAR const
char *"
-"ioctl","sys/ioctl.h","!defined(CONFIG_LIBC_IOCTL_VARIADIC)","int","int","int","unsigned
long"
+"ioctl","sys/ioctl.h","","int","int","int","..."

Review comment:
       
   > Since all these functions just accept one more argument from standard, we can modify
mksyscall not to hard code the max number to 7 instead geting it from syscall.cvs like this:
   > 
   > ```
   > "open","fcntl.h","","int","const char*","int","...1"
   
   I think that is a good idea.  That would greatly improve performance.  It doesn't resolve
the issue of the type of the argument; it would still assume that it is a uintptr_t even though
in reality it is a mode_t or unsigned int.
   
   That would not work for something like syslog() which has an arbitrarily long list of arguments
of various types, perhaps as many as 20 or more.
   
   "..." must always be the last argument.  So perhaps "...N" could be followed by a list
of N types like: "...1","mode_t" could mean that there is at most one argument of type mode_t.
 That would also solve the typing issue.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message