nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #965: fs: Remove all LIBC_IOCTL_VARIADIC related stuff
Date Tue, 05 May 2020 13:44:54 GMT

patacongo commented on a change in pull request #965:
URL: https://github.com/apache/incubator-nuttx/pull/965#discussion_r420120217



##########
File path: syscall/syscall_stublookup.c
##########
@@ -189,13 +189,9 @@ uintptr_t STUB_nx_vsyslog(int nbr, uintptr_t parm1, uintptr_t parm2,
  */
 
 uintptr_t STUB_close(int nbr, uintptr_t parm1);
-#ifdef CONFIG_LIBC_IOCTL_VARIADIC
-uintptr_t STUB_fs_ioctl(int nbr, uintptr_t parm1, uintptr_t parm2,
-            uintptr_t parm3);
-#else
 uintptr_t STUB_ioctl(int nbr, uintptr_t parm1, uintptr_t parm2,
-            uintptr_t parm3);
-#endif
+            uintptr_t parm3, uintptr_t parm4, uintptr_t parm5,
+            uintptr_t parm6);

Review comment:
       This is terrible.  I am very strongly opposed to this and will not merge this PR with
this kind of code.  Very bad.
   
   Please follow the model of syslog, vsyslog, and nx_vsyslog.  That will work.  This is bad.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message