nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] btashton commented on pull request #953: x86_64: Make sure to clone ap list in vasprintf
Date Sun, 03 May 2020 17:14:39 GMT

btashton commented on pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#issuecomment-623146530


   > > @patacongo
   > > It looks like we do check for x86_64 in the sim
   > > 
   > > ```
   > > #elif defined(CONFIG_ARCH_SIM) && (defined(CONFIG_HOST_X86) || defined(CONFIG_HOST_X86_64))
   > > # define CLONE_APLIST 1
   > > # undef ap2
   > > #endif
   > > ```
   > 
   > Yes, that's why I suggest to trigger the copy by checking va_copy existence instead
of arch macro.
   
   Ah I misunderstood. I thought you were asking me to add the arch macro to this code.
   
   I think this might add the copy to architectures where we could avoid copying, but I'll
need to take a look at the headers. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message