nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo edited a comment on issue #951: libc ioctl not compatible with 64bit hardware
Date Sun, 03 May 2020 17:00:17 GMT

patacongo edited a comment on issue #951:
URL: https://github.com/apache/incubator-nuttx/issues/951#issuecomment-623134975


   > Can we change this debug assert to `sizeof(int) <= sizeof(unsigned long) ` without
causing issues?
   
   This could actually cause issues, couldn't it?  But there are a lot of issues now that
we have made the variadic ioctl() the only interface.  I will submit an Issue.
   
   Whether it is safe or not will depending (1) the sizeof(int) and (2) on the implementation
of va_arg.  If there are differences in size and if va_arg uses some byte-oriented addressing
they yes it would be an issue that is is extracting an 8-byte value when the provided value
is only 4-bytes, for example.  But this issue is much bigger than just that.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message