nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #953: x86_64: Make sure to clone ap list in vasprintf
Date Sun, 03 May 2020 16:31:01 GMT

xiaoxiang781216 commented on a change in pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#discussion_r419127094



##########
File path: libs/libc/stdio/lib_vasprintf.c
##########
@@ -58,7 +58,7 @@
 #define ap1 ap
 #define ap2 ap
 
-#if defined(CONFIG_ARCH_X86)
+#if defined(CONFIG_ARCH_X86) || defined(CONFIG_ARCH_X86_64)

Review comment:
       It isn't a big issue because va_copy is a simple pointer assignment for no x64 like
platform.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message