nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #953: x86_64: Make sure to clone ap list in vasprintf
Date Sun, 03 May 2020 12:51:28 GMT

patacongo commented on a change in pull request #953:
URL: https://github.com/apache/incubator-nuttx/pull/953#discussion_r419098991



##########
File path: libs/libc/stdio/lib_vasprintf.c
##########
@@ -58,7 +58,7 @@
 #define ap1 ap
 #define ap2 ap
 
-#if defined(CONFIG_ARCH_X86)
+#if defined(CONFIG_ARCH_X86) || defined(CONFIG_ARCH_X86_64)

Review comment:
       We do need to do something differently.  Architectural dependencies or conditional
logic  are not permitted in common code.  We control all architecture-specific logic under
libs/linc/machine or in header files at include/arch.
   
   X86 was there before, but that was incorrect.  That is the problem with putting things
in the wrongplce:  It attracts more things in the wrong place.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message