nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #943: Refine the github related setting
Date Sat, 02 May 2020 06:08:57 GMT

xiaoxiang781216 commented on a change in pull request #943:
URL: https://github.com/apache/incubator-nuttx/pull/943#discussion_r418918757



##########
File path: .asf.yaml
##########
@@ -14,9 +14,5 @@ github:
     - mcu
     - microcontroller
   enabled_merge_buttons:
-    # enable squash button:
-    squash:  true

Review comment:
       > elieve squashing can come in handy.
   
   We can ask contributor to do squash if need. In this way, contributor will learn how to
organize the patch series in a better way and apply the knowledge in the furture PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message