nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] yamt commented on a change in pull request #933: sim: Suppress "has no symbols" warnings for macOS
Date Sat, 02 May 2020 01:52:29 GMT

yamt commented on a change in pull request #933:
URL: https://github.com/apache/incubator-nuttx/pull/933#discussion_r418824716



##########
File path: binfmt/Makefile
##########
@@ -47,6 +47,7 @@ BINFMT_ASRCS  =
 BINFMT_CSRCS  = binfmt_globals.c binfmt_initialize.c binfmt_register.c binfmt_unregister.c
 BINFMT_CSRCS += binfmt_loadmodule.c binfmt_unloadmodule.c binfmt_execmodule.c
 BINFMT_CSRCS += binfmt_exec.c binfmt_copyargv.c binfmt_dumpmodule.c
+BINFMT_CSRCS += dummy.c

Review comment:
       i feel we merge patches too quickly. can we wait for at least one day when a patch
is controversial?
   
   the merged patch is IMO too much hack. it even pollutes the end binary.
   if you don't like my approach in this patch, you can just remove the warnings in the wrapper
script instead.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message