nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #933: sim: Suppress "has no symbols" warnings for macOS
Date Fri, 01 May 2020 09:53:59 GMT

xiaoxiang781216 commented on a change in pull request #933:
URL: https://github.com/apache/incubator-nuttx/pull/933#discussion_r418483568



##########
File path: binfmt/Makefile
##########
@@ -47,6 +47,7 @@ BINFMT_ASRCS  =
 BINFMT_CSRCS  = binfmt_globals.c binfmt_initialize.c binfmt_register.c binfmt_unregister.c
 BINFMT_CSRCS += binfmt_loadmodule.c binfmt_unloadmodule.c binfmt_execmodule.c
 BINFMT_CSRCS += binfmt_exec.c binfmt_copyargv.c binfmt_dumpmodule.c
+BINFMT_CSRCS += dummy.c

Review comment:
       We hit the similar issue with ceva toolchain before, and find a general solution:
   ```
   # cofflib -r will core dump if the library contain an object file
   # without any public symbol, so let's always generate a dummy global
   # function to overcome this issue.
   ARCHCPUFLAGS += -DCKSUM_SELF=$(if $<,$(word 1,$(shell cksum $<)))
   ARCHCPUFLAGS += -include dummy.h
   ```
   Here is two related files:
   https://github.com/FishsemiCode/nuttx/blob/song-u1/arch/ceva/src/tl4/Toolchain.defs
   https://github.com/FishsemiCode/nuttx/blob/song-u1/arch/ceva/src/tl4/dummy.h
   Without a general solution, we have to fix the same issue again and again.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message