From commits-return-7405-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Thu Apr 16 17:47:05 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E6F3018066D for ; Thu, 16 Apr 2020 19:47:04 +0200 (CEST) Received: (qmail 25774 invoked by uid 500); 16 Apr 2020 17:47:04 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 25752 invoked by uid 99); 16 Apr 2020 17:47:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Apr 2020 17:47:04 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 2F9B68B6AD; Thu, 16 Apr 2020 17:47:04 +0000 (UTC) Date: Thu, 16 Apr 2020 17:47:04 +0000 To: "commits@nuttx.apache.org" Subject: [incubator-nuttx] 01/04: netlink: Fix the compiler warning in netlink_add_broadcast MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: gnutt@apache.org In-Reply-To: <158705922388.21736.9138723008690137787@gitbox.apache.org> References: <158705922388.21736.9138723008690137787@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-nuttx X-Git-Refname: refs/heads/pr807 X-Git-Reftype: branch X-Git-Rev: 0c630d79f9d3e2630983ff40c0da98c7d7fef9a4 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20200416174704.2F9B68B6AD@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. gnutt pushed a commit to branch pr807 in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 0c630d79f9d3e2630983ff40c0da98c7d7fef9a4 Author: Xiang Xiao AuthorDate: Thu Apr 16 13:50:20 2020 +0800 netlink: Fix the compiler warning in netlink_add_broadcast netlink/netlink_conn.c: In function 'netlink_add_broadcast': netlink/netlink_conn.c:319:45: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] 319 | if (conn->groups & (1 << (group - 1)) == 0) | ~~~~~~~~~~~~~~~~~~~^~~~ Signed-off-by: Xiang Xiao Change-Id: I1bee7933dca1bdd118d0034a564b4306e1ae5684 --- net/netlink/netlink_conn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netlink/netlink_conn.c b/net/netlink/netlink_conn.c index 9145ef2..96aed71 100644 --- a/net/netlink/netlink_conn.c +++ b/net/netlink/netlink_conn.c @@ -317,7 +317,7 @@ void netlink_add_broadcast(int group, FAR struct netlink_response_s *data) while ((conn = netlink_nextconn(conn)) != NULL) { - if (conn->groups & (1 << (group - 1)) == 0) + if ((conn->groups & (1 << (group - 1))) == 0) { continue; }