From commits-return-8340-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Tue Apr 28 15:20:48 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 65573180647 for ; Tue, 28 Apr 2020 17:20:48 +0200 (CEST) Received: (qmail 35719 invoked by uid 500); 28 Apr 2020 15:20:47 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 35649 invoked by uid 99); 28 Apr 2020 15:20:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Apr 2020 15:20:47 +0000 From: =?utf-8?q?GitBox?= To: commits@nuttx.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-nuttx=5D_patacongo_commented_on_pull_req?= =?utf-8?q?uest_=23834=3A_tools/zipme=2Esh=3A_Let_major=2Eminor=2Epatch_argu?= =?utf-8?q?ment_optional?= Message-ID: <158808724772.3807.5708361203242963593.asfpy@gitbox.apache.org> Date: Tue, 28 Apr 2020 15:20:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: patacongo commented on pull request #834: URL: https://github.com/apache/incubator-nuttx/pull/834#issuecomment-620673536 > If we remove `.version` with each `make distclean` then the version will be 0.0.0 after a distclean with a tarball because there is no .git directory to fall back to. True. We must retain the .version file. We have to handle the use cases where (1) there is no GIT information available, and (2) end-users have a custom, hand-editted version of the .version file which they use to identify specific product releases which may be unrelated to NuttX releases. We can only achieve backward compatibility and we can only accomplish the end-user usage cases be retaining the .version file. It must never be deleted. We have gone through this discussion numerous times, but it keeps coming back. The .version file contains information which may or may not be related to the NuttX release. A default version is created in the release, but there must be no assumption made about the content of the .version file, and it must survive all command line operations (with the exeption only of 'rm .version') ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org