From commits-return-7733-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Tue Apr 21 06:44:45 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7585918065D for ; Tue, 21 Apr 2020 08:44:45 +0200 (CEST) Received: (qmail 91617 invoked by uid 500); 21 Apr 2020 06:44:44 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 91608 invoked by uid 99); 21 Apr 2020 06:44:44 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Apr 2020 06:44:44 +0000 From: =?utf-8?q?GitBox?= To: commits@nuttx.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-nuttx=5D_xiaoxiang781216_commented_on_is?= =?utf-8?q?sue_=23757=3A_Create_release_artifacts_for_release_branches?= Message-ID: <158745148468.29173.18018753143633962101.asfpy@gitbox.apache.org> Date: Tue, 21 Apr 2020 06:44:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: xiaoxiang781216 commented on issue #757: URL: https://github.com/apache/incubator-nuttx/pull/757#issuecomment-616986400 > I do _not_ want to match `nuttx-some-fix` and more importantly at some point we will tag > 9.1 and may still backport and only want to match 9.0.# not 9.1.# > We can get this information by: ``` git branch --show-current ``` > `version.sh` is expecting to be passed a full version string `gitversion.sh` can provide this value to it in the context of a CI run. It really does not make sense outside of a CI run, but it is complicated enough I did not want to shove it in the yaml file. > No, version.sh is also used when the user who clone git directly. In this case, .version is automatically generated in the build process by version.sh. We must ensure that the generated version number is same regardless which method user is used to get the package. > ``` > $ version.sh -v `gitversion.sh 0.1` > ``` > > `version.sh` job is really just setting the config files. The fact that it tries to guess a version number from git is out of its job in my opinion. Why not drop version being optional and just: > > ``` > version.sh -v `git describe --match nuttx-[0-9].* --abbrev=0` > ``` As I note before, we need consider the user who use repo directly and merge the upstream regularly after each major release. version.sh is only method here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org