From commits-return-7577-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Sat Apr 18 13:41:55 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 594B8180663 for ; Sat, 18 Apr 2020 15:41:55 +0200 (CEST) Received: (qmail 54364 invoked by uid 500); 18 Apr 2020 13:41:54 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 54355 invoked by uid 99); 18 Apr 2020 13:41:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Apr 2020 13:41:54 +0000 From: GitBox To: commits@nuttx.apache.org Subject: [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #826: github: Add PR Template Message-ID: <158721731449.13624.11426046933424105024.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 18 Apr 2020 13:41:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit patacongo commented on a change in pull request #826: github: Add PR Template URL: https://github.com/apache/incubator-nuttx/pull/826#discussion_r410700036 ########## File path: .github/PULL_REQUEST_TEMPLATE.md ########## @@ -0,0 +1,68 @@ +# Pull Request Template + +## Title guidelines + +Following the guidelines for writting good commit messages (https://chris.beams.io/posts/git-commit/) and creating a meaningful title is key in effective team communication. + +**do's** +- stm32h7:Add SDMMC Support +- nsh:Separate `source` and `sh` for POSIX compliance +- nxstyle:Fixed Camel case detection +- drivers/serial:Fixed style violation + Review comment: The English language requires two spaces following a colon. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services