From commits-return-7574-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Sat Apr 18 13:24:58 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 689D1180663 for ; Sat, 18 Apr 2020 15:24:58 +0200 (CEST) Received: (qmail 40926 invoked by uid 500); 18 Apr 2020 13:24:57 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 40917 invoked by uid 99); 18 Apr 2020 13:24:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Apr 2020 13:24:57 +0000 From: GitBox To: commits@nuttx.apache.org Subject: [GitHub] [incubator-nuttx-apps] davids5 commented on issue #185: nsh improvement Message-ID: <158721629769.25598.7292319723403900520.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 18 Apr 2020 13:24:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit davids5 commented on issue #185: nsh improvement URL: https://github.com/apache/incubator-nuttx-apps/pull/185#issuecomment-615870966 @patacongo - Do you see any harm in renaming sh to `source` and `.` I would also add the concern of stack nesting and fragmentation to the list. Please contrast the existing implementation to the proposed one in terms of stack nesting and fragmentation when the /etc/rind.d/rcS has `sh ./l1` and l1 has `sh .l2` From a small platform with the goal of having a clean set of scripts, that really just needs `sh` to include the as if it were one file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services