From commits-return-7557-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Sat Apr 18 11:44:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EF7D7180663 for ; Sat, 18 Apr 2020 13:44:02 +0200 (CEST) Received: (qmail 17453 invoked by uid 500); 18 Apr 2020 11:44:02 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 17444 invoked by uid 99); 18 Apr 2020 11:44:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Apr 2020 11:44:02 +0000 From: GitBox To: commits@nuttx.apache.org Subject: [GitHub] [incubator-nuttx-apps] davids5 commented on a change in pull request #185: nsh improvement Message-ID: <158721024237.9828.17341249727303387733.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 18 Apr 2020 11:44:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit davids5 commented on a change in pull request #185: nsh improvement URL: https://github.com/apache/incubator-nuttx-apps/pull/185#discussion_r410687476 ########## File path: nshlib/nsh.h ########## @@ -1008,10 +1008,15 @@ int cmd_irqinfo(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv); int cmd_readlink(FAR struct nsh_vtbl_s *vtbl, int argc, char **argv); #endif #if CONFIG_NFILE_STREAMS > 0 && !defined(CONFIG_NSH_DISABLESCRIPT) -# ifndef CONFIG_NSH_DISABLE_SH +#if !defined(CONFIG_NSH_DISABLE_SH) && defined(CONFIG_SYSTEM_SYSTEM) Review comment: @xiaoxiang781216 - Thank you! are you implementing "." for source? The would help, on constrained platforms. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services