From commits-return-7424-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Thu Apr 16 18:53:32 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AB7FE180638 for ; Thu, 16 Apr 2020 20:53:32 +0200 (CEST) Received: (qmail 92435 invoked by uid 500); 16 Apr 2020 18:53:32 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 92426 invoked by uid 99); 16 Apr 2020 18:53:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Apr 2020 18:53:32 +0000 From: GitBox To: commits@nuttx.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-nuttx-apps=5D_patacongo_commented_on_?= =?utf-8?q?a_change_in_pull_request_=23183=3A_nshlib/nsh=5Fcodeccmd=2Ec=3A?= =?utf-8?q?_fix_potential_NULL_dereference_and_check_mallo=E2=80=A6?= Message-ID: <158706321207.9183.13926589057038389520.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 16 Apr 2020 18:53:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit patacongo commented on a change in pull request #183: nshlib/nsh_codeccmd.c: fix potential NULL dereference and check mallo… URL: https://github.com/apache/incubator-nuttx-apps/pull/183#discussion_r409778427 ########## File path: include/netutils/md5.h ########## @@ -74,24 +73,24 @@ extern "C" * Public Types ****************************************************************************/ -struct MD5Context +struct md5_context_s { uint32_t buf[4]; uint32_t bits[2]; uint8_t in[64]; }; -typedef struct MD5Context MD5_CTX; +typedef struct md5_context_s MD5_CTX; Review comment: Hmm... there are other examples where upper case types are used for handles (after Microsoft conventions). I suppose we should end that practice because it is non-compliant with the standard. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services