From commits-return-7194-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Tue Apr 14 22:37:33 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5A5E918066D for ; Wed, 15 Apr 2020 00:37:33 +0200 (CEST) Received: (qmail 68876 invoked by uid 500); 14 Apr 2020 22:37:32 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 68865 invoked by uid 99); 14 Apr 2020 22:37:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Apr 2020 22:37:32 +0000 From: GitBox To: commits@nuttx.apache.org Subject: [GitHub] [incubator-nuttx] davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx Message-ID: <158690385276.15629.3455257225761930153.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 14 Apr 2020 22:37:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit davids5 commented on a change in pull request #745: [DO NOT MERGE] arch/stm32h7: Explicit support for all STM32H7x3xx URL: https://github.com/apache/incubator-nuttx/pull/745#discussion_r408475913 ########## File path: arch/arm/src/stm32h7/stm32_gpio.c ########## @@ -162,6 +162,20 @@ int stm32_configgpio(uint32_t cfgset) return -EINVAL; } +#if (STM32H7_NGPIO > 5) && (!defined(CONFIG_STM32H7_HAVE_GPIOF)) Review comment: Can all this be just a null check on line 181? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services