From commits-return-7034-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Mon Apr 13 15:58:37 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C1E5218062C for ; Mon, 13 Apr 2020 17:58:36 +0200 (CEST) Received: (qmail 28533 invoked by uid 500); 13 Apr 2020 15:58:36 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 28523 invoked by uid 99); 13 Apr 2020 15:58:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Apr 2020 15:58:36 +0000 From: GitBox To: commits@nuttx.apache.org Subject: [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #772: nuttx: Fix the nightly build warning Message-ID: <158679351604.14732.4797078462336864223.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 13 Apr 2020 15:58:36 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit patacongo commented on a change in pull request #772: nuttx: Fix the nightly build warning URL: https://github.com/apache/incubator-nuttx/pull/772#discussion_r407554097 ########## File path: arch/mips/src/pic32mx/pic32mx-usbdev.c ########## @@ -2347,25 +2405,25 @@ static void pic32mx_ep0setup(struct pic32mx_usbdev_s *priv) /* At this point, the request has been handled and there are three possible * outcomes: * - * 1. The setup request was successfully handled above and a response packet - * must be sent (may be a zero length packet). + * 1. The setup request was successfully handled above and a response + * packet must be sent (may be a zero length packet). * 2. The request was successfully handled by the class implementation. In - * case, the EP0 IN response has already been queued and the local variable - * 'dispatched' will be set to true and ctrlstate != CTRLSTATE_STALL; - * 3. An error was detected in either the above logic or by the class implementation - * logic. In either case, priv->state will be set CTRLSTATE_STALL - * to indicate this case. + * variable case, the EP0 IN response has already been queued and the + * local dispatched will be set to true and ctrlstate != CTRLSTATE_STALL Review comment: The word 'this' is missing beween "In case" The word variable belongs on line 2412 after local The single quotes around 'dispatched' are really necessary to make the sense readable. Otherwise, it looks like a word in the sentence, not a variable name. ctrlstate does not have this confusion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services