From commits-return-6894-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Sat Apr 11 16:29:16 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 40F1D180181 for ; Sat, 11 Apr 2020 18:29:16 +0200 (CEST) Received: (qmail 44603 invoked by uid 500); 11 Apr 2020 16:29:15 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 44594 invoked by uid 99); 11 Apr 2020 16:29:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Apr 2020 16:29:15 +0000 From: GitBox To: commits@nuttx.apache.org Subject: [GitHub] [incubator-nuttx] patacongo edited a comment on issue #765: sched/sched_setpriority.c: DEBUGVERIFY, not DEBUGASSERT. Message-ID: <158662255556.27359.18001086787393539942.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 11 Apr 2020 16:29:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit patacongo edited a comment on issue #765: sched/sched_setpriority.c: DEBUGVERIFY, not DEBUGASSERT. URL: https://github.com/apache/incubator-nuttx/pull/765#issuecomment-612453692 This error has been around since August 24, 2019. It was introduced by commit e1202d2ed33a257cd6d812fde8c3a77a4d7c1d01 See https://github.com/apache/incubator-nuttx/commit/e1202d2ed33a257cd6d812fde8c3a77a4d7c1d01 That commit changed all occurrences of ASSERT to DEBUGASSERT. The logical flaw in do that is that the logic withing ASSERT runs unconditionally. Changing to DEBUGASSERT causes the logic to only execute conditionally, introducing this error. I suppose in retrospect that the simplest solution would have been to simply restore the ASSERT since the condition that is tested would be an OS failure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services