From commits-return-6574-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Sun Apr 5 23:19:23 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 11046180638 for ; Mon, 6 Apr 2020 01:19:22 +0200 (CEST) Received: (qmail 93595 invoked by uid 500); 5 Apr 2020 23:19:22 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 93586 invoked by uid 99); 5 Apr 2020 23:19:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Apr 2020 23:19:22 +0000 From: GitBox To: commits@nuttx.apache.org Subject: [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS Message-ID: <158612876231.24084.7170628497761151161.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 05 Apr 2020 23:19:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit patacongo commented on a change in pull request #684: boards/arm/stm32h7/stm32h747i-disco: bring support for SD card and FAT FS URL: https://github.com/apache/incubator-nuttx/pull/684#discussion_r403771526 ########## File path: boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c ########## @@ -0,0 +1,175 @@ +/**************************************************************************** + * boards/arm/stm32h7/stm32h747i-disco/src/stm32_sdmmc.c + * + * Copyright (C) 2016-2019 Gregory Nutt. All rights reserved. + * Author: Gregory Nutt + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: Review comment: Ahh... talking with Abdelatif, I missunderstood the question. I am the copyright holder and the old SDMMC code and do give my approval to change the license header to the Apache 2.0 license header cited above. The one with the PX4 copyright must also have an Apache 2.0 header to be considered. BTW: The current version of my original SDMMC file does now have an Apache header and also includes requires changes that you do not have in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services