From commits-return-6406-archive-asf-public=cust-asf.ponee.io@nuttx.apache.org Fri Apr 3 13:56:33 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8491218064F for ; Fri, 3 Apr 2020 15:56:33 +0200 (CEST) Received: (qmail 33260 invoked by uid 500); 3 Apr 2020 13:56:33 -0000 Mailing-List: contact commits-help@nuttx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nuttx.apache.org Delivered-To: mailing list commits@nuttx.apache.org Received: (qmail 33251 invoked by uid 99); 3 Apr 2020 13:56:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Apr 2020 13:56:32 +0000 From: GitBox To: commits@nuttx.apache.org Subject: [GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count. Message-ID: <158592219283.14067.17027506181277133428.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 03 Apr 2020 13:56:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit xiaoxiang781216 commented on a change in pull request #161: netutils/dhcpc: configurable timeout and retry count. URL: https://github.com/apache/incubator-nuttx-apps/pull/161#discussion_r403023220 ########## File path: netutils/dhcpc/dhcpc.c ########## @@ -433,7 +433,7 @@ FAR void *dhcpc_open(FAR const char *interface, FAR const void *macaddr, /* Configure for read timeouts */ - tv.tv_sec = 10; + tv.tv_sec = CONFIG_NETUTILS_DHCPC_RECV_TIMEOUT; Review comment: 10sec for the timeout is too large for the most nowaday network, especially for DHCP transaction which always happen between two nodes directly without any intermediate node. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services