nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo opened a new issue #718: nxstyle: No line with check on single line comments.
Date Sat, 04 Apr 2020 00:30:09 GMT
patacongo opened a new issue #718: nxstyle:  No line with check on single line comments.
URL: https://github.com/apache/incubator-nuttx/issues/718
 
 
   I haven't really verified this thoroughly, but nxstyle appears to skeip the line with check
on some or all single line comments.
   
   Certainly, it ignores the line width check on right hand comments all or most of the time.
 Those often extend will beyond the section headers.
   
   Fixing the later would probably cause more problems than it would be worth.  We would need
to consider that carefully.  Forcing all right hand commits to conform to the line width would
like generate a lot of work for us and likely some discontent from contributors.
   
   In .h files, it is not such a big issue because you can always extend the block comment
with a little if need be.  But this problem also occurs in the Pre-processor Definitions,
 Private Types, and Private Data sections of .c files.  We would not want to have to extend
the line width of the whole C file to accomodate that.
   
   So I think there is a issue with the current nxstyle behavior and probably issues with
correcting that behavior in all cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message