nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #915: Change all function prefix from up_ to arch_ in include/nuttx/arch.h
Date Thu, 30 Apr 2020 16:51:25 GMT

xiaoxiang781216 edited a comment on issue #915:
URL: https://github.com/apache/incubator-nuttx/issues/915#issuecomment-621967674


   > In #916, the error is in the name up_fullcontextrestore(tcb->xcp.regs); which is
incorrect. That should be arm_fullcontextrestore(). The naming in other ARM architectures
is incorrect. The other architectures are not following the naming standard. ARMv8-M is correctly
following the naming standard.
   > 
   > So yes, there will be issues UNTIL other ARM architectures are mad to follow the naming
standard. Let's do that!! Let's fix the other ARM architectures and not screw up the naming
standard.
   
   We just want to change up_xxx function common across armv7-a, armv7-m... to arm_xxx, but
up_ is also used for the common function across arm, riscv..., so it is impossible to replace
all up_ inside arch/arm to arm_ auotmaitcally.
   if https://cwiki.apache.org/confluence/display/NUTTX/Naming+FAQ state correctly, arch_
is better prefix than up_. We can apply the sequence I suggested before:
   1.Rename functions in arch.h from up_xxx to arch_xxx
   2.Rename files in arch/yyy/ from up_xxx.* to yyy_xxx.*
   3.Rename function in arch/yyy/ from up_xxx to yyy_xxx
   Since functions for all arch change to arm_ in the first step, we can find the remaining
up_xxx and replace with arm_xxx safely and automatically.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message