nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #911: Use NuttX's signal set functions inside the OS.
Date Wed, 29 Apr 2020 21:14:02 GMT

Ouss4 commented on a change in pull request #911:
URL: https://github.com/apache/incubator-nuttx/pull/911#discussion_r417615597



##########
File path: sched/signal/sig_dispatch.c
##########
@@ -362,7 +363,7 @@ int nxsig_tcbdispatch(FAR struct tcb_s *stcb, siginfo_t *info)
 
       flags = enter_critical_section();
       if (stcb->task_state == TSTATE_WAIT_SIG &&
-          sigismember(&stcb->sigwaitmask, info->si_signo))
+          nxsig_ismember(&stcb->sigwaitmask, info->si_signo))

Review comment:
       In this case signo was already tested by the first call to nxsig_ismember.  If we are
executing this code, signo shall be valid.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message