nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] sonicyang commented on a change in pull request #904: Resolve linking issues with x86_64 port
Date Wed, 29 Apr 2020 15:33:59 GMT

sonicyang commented on a change in pull request #904:
URL: https://github.com/apache/incubator-nuttx/pull/904#discussion_r417409384



##########
File path: arch/x86_64/src/intel64/intel64_lowsetup.c
##########
@@ -64,16 +77,16 @@ void up_lowsetup(void)
 
   /* Setup pointers for accessing Page table and GDT in high address */
 
-  pdpt = &pdpt_low + X86_64_LOAD_OFFSET;
-  pd   = &pd_low   + X86_64_LOAD_OFFSET;
-  pt   = &pt_low   + X86_64_LOAD_OFFSET;
+  pdpt = (uint64_t *)((uint64_t)&pdpt_low + X86_64_LOAD_OFFSET);
+  pd   = (uint64_t *)((uint64_t)&pd_low   + X86_64_LOAD_OFFSET);
+  pt   = (uint64_t *)((uint64_t)&pt_low   + X86_64_LOAD_OFFSET);
 
-  ist64     = (struct ist_s *)((void *)&ist64_low       + X86_64_LOAD_OFFSET);
-  gdt64     = (struct gdt_entry_s *)((void *)&gdt64_low + X86_64_LOAD_OFFSET);
+  ist64     = (struct ist_s *)((uint64_t)&ist64_low       + X86_64_LOAD_OFFSET);
+  gdt64     = (struct gdt_entry_s *)((uint64_t)&gdt64_low + X86_64_LOAD_OFFSET);

Review comment:
       Although this code was not intended to be portable, I do think, using uintptr_t is
a better idea.
   (Including the definition of pdpt, pd, and pt)
   
   I did used uint64_t during my porting, but later I found out that the code's logic might,
somehow, be compatible with x86_32.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message