nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on pull request #834: tools/zipme.sh: Let major.minor.patch argument optional
Date Tue, 28 Apr 2020 15:20:47 GMT

patacongo commented on pull request #834:
URL: https://github.com/apache/incubator-nuttx/pull/834#issuecomment-620673536


   > If we remove `.version` with each `make distclean` then the version will be 0.0.0
after a distclean with a tarball because there is no .git directory to fall back to.
   
   True.  We must retain the .version file.  We have to handle the use cases where (1) there
is no GIT information available, and (2) end-users have a custom, hand-editted version of
the .version file which they use to identify specific product releases which may be unrelated
to NuttX releases.
   
   We can only achieve backward compatibility and we can only accomplish the end-user usage
cases be retaining the .version file.  It must never be deleted.
   
   We have gone through this discussion numerous times, but it keeps coming back.  The .version
file contains information which may or may not be related to the NuttX release.  A default
version is created in the release, but there must be no assumption made about the content
of the .version file, and it must survive all command line operations (with the exeption only
of 'rm .version')


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message