nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on a change in pull request #872: nuttx: Change all default stack size to DEFAULT_TASK_STACKSIZE
Date Sat, 25 Apr 2020 16:56:56 GMT

patacongo commented on a change in pull request #872:
URL: https://github.com/apache/incubator-nuttx/pull/872#discussion_r415100445



##########
File path: boards/arm/sama5/sama5d3x-ek/Kconfig
##########
@@ -180,8 +180,7 @@ endchoice # AT24 serial EPPROM configuration
 
 config SAMA5D3xEK_USBHOST_STACKSIZE
 	int "USB host waiter stack size"
-	default 1536 if USBHOST_HUB
-	default 1024 if !USBHOST_HUB

Review comment:
       It is inappropriate to increase the size of this tuned stack size.  Let's not do that.

##########
File path: boards/arm/sama5/sama5d4-ek/Kconfig
##########
@@ -323,8 +323,7 @@ endif # SAMA5D4EK_ROMFS_MOUNT
 
 config SAMA5D4EK_USBHOST_STACKSIZE
 	int "USB host waiter stack size"
-	default 1536 if USBHOST_HUB
-	default 1024 if !USBHOST_HUB

Review comment:
       It is inappropriate to increase the size of this tuned stack size.  Let's not do that.

##########
File path: boards/arm/stm32/olimex-stm32-p407/Kconfig
##########
@@ -7,7 +7,7 @@ if ARCH_BOARD_OLIMEX_STM32P407
 
 config STM32F4DISCO_OLIMEXP407_STACKSIZE
 	int "USB host waiter stack size"
-	default 1024

Review comment:
       It is inappropriate to increase the size of this tuned stack size.  Let's not do that.

##########
File path: boards/arm/stm32/photon/Kconfig
##########
@@ -46,7 +46,7 @@ config PHOTON_WDG_THREAD_PRIORITY
 
 config PHOTON_WDG_THREAD_STACKSIZE
 	int "Watchdog Thread Stacksize"
-	default 1024

Review comment:
       It is inappropriate to increase the size of this tuned stack size.  Let's not do that.

##########
File path: boards/arm/stm32/stm32f411e-disco/Kconfig
##########
@@ -7,7 +7,7 @@ if ARCH_BOARD_STM32F411E_DISCO
 
 config STM32F411DISCO_USBHOST_STACKSIZE
 	int "USB host waiter stack size"
-	default 1024

Review comment:
       **It is inappropriate to increase the size of this tuned stack size.  Let's not do
that.**

##########
File path: boards/arm/stm32/stm32f429i-disco/Kconfig
##########
@@ -86,7 +86,7 @@ config STM32F429I_DISCO_RAMMTD_SIZE
 
 config STM32F429IDISCO_USBHOST_STACKSIZE
 	int "USB host waiter stack size"
-	default 1024

Review comment:
       It is inappropriate to increase the size of this tuned stack size.  Let's not do that.

##########
File path: boards/arm/stm32/stm32f4discovery/Kconfig
##########
@@ -36,7 +36,7 @@ config STM32_ROMFS_IMAGEFILE
 
 config STM32F4DISCO_USBHOST_STACKSIZE
 	int "USB host waiter stack size"
-	default 1024

Review comment:
       It is inappropriate to increase the size of this tuned stack size.  Let's not do that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message