nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on issue #652: NXStyle: Ignore alignments of block comments at right of code
Date Sat, 25 Apr 2020 14:13:31 GMT

patacongo commented on issue #652:
URL: https://github.com/apache/incubator-nuttx/issues/652#issuecomment-619385870


   Nope, no long line is reported. Here is the modified junk.c file:
   
       /****************************************************************************
        * junk.c
        ****************************************************************************/
       
       /****************************************************************************
        * Included Files
        ****************************************************************************/
       
       #include <stdint.h>
       
       /****************************************************************************
        * Private Types
        ****************************************************************************/
       
       struct a_struct_s
       {
         uint8_t f1; /* This is a very long line in a single right-hand comment, No error
is reported OK. */
         uint8_t f2; /* This is a a very long line in a block comment.  In this case nxstyle
complains
                      * and an error is reported.
                      */
       };
       
       /****************************************************************************
        * Public Functions
        ****************************************************************************/
       
   But nxstyle does not complain about the long lines at all.  I am not sure that that is
good.  It is good for now, but there is no exception in the coding standard for long right
hand comments.  They are also a violation of the coding standard, we just do not want to deal
with them now:
   
   The long right hand comments in **arch/arm/src/imxrt/imxrt_enc.c** no longer generate errors
either.  So I conclude that this issue as reported no longer exists.  I believe that there
are still issues wtih long lines:  They should be reported.  But given the context of this
issue, it can be closed now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message