nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo commented on issue #652: NXStyle: Ignore alignments of block comments at right of code
Date Sat, 25 Apr 2020 13:56:37 GMT

patacongo commented on issue #652:
URL: https://github.com/apache/incubator-nuttx/issues/652#issuecomment-619383532


   Looking back through the PR chekcs for I think I see the issue you are referring to: https://github.com/apache/incubator-nuttx/runs/562410318?check_suite_focus=true
   
   The file is  arch/arm/src/imxrt/imxrt_enc.c and these errors were reported:
   
       arch/arm/src/imxrt/imxrt_enc.c:266:78: error: Long line found
       arch/arm/src/imxrt/imxrt_enc.c:269:78: error: Long line found
       arch/arm/src/imxrt/imxrt_enc.c:272:82: error: Long line found
       arch/arm/src/imxrt/imxrt_enc.c:273:80: error: Long line found
       arch/arm/src/imxrt/imxrt_enc.c:296:78: error: Long line found
   
   Looking at those, I see that these are not related to the right hand comments at all. 
These are simply saying that the lines are too long.  I verfied each that this is the case.
 The ARE too long.
   
   When I run the current nxstyle against the current imxrt_enc.c I get:
   
       $ tools/nxstyle.exe arch/arm/src/imxrt/imxrt_enc.c
       arch/arm/src/imxrt/imxrt_enc.c:1037:81: error: Long line found
       arch/arm/src/imxrt/imxrt_enc.c:1043:84: error: Long line found
   
   To things to note:
   
   1. The errors at liness 266-296 no longer appear.  That is a regression.  They truly are
too long.
   2. New long lines are reported at 1037 and 1043.  These are correct and appear not due
to a recent fix to nxstyle.
   
   So I am thinking that this Issue should be closed.  Please give your feeback before I close
it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message