nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo edited a comment on issue #836: audio nxstyle fixes and audio drivers cleanup
Date Tue, 21 Apr 2020 15:20:14 GMT

patacongo edited a comment on issue #836:
URL: https://github.com/apache/incubator-nuttx/pull/836#issuecomment-617246009


   > You cannot change audio.h or any other common header file without also changing ALL
of the files that include that header files. You can either:
   > 
   >     1. Back out the changes that you mad to common header files, or,
   >     2. Change all places where those common header files are included.
   
   it looks like you already did (2) in the nuttx/ repository.  But you will also have to
do that in the apps/ repository as well.
   
   They you will have the situation where you must have both PRs in place in order for either
of them to pass the build checks.  So the PR checks will still fail.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message