nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] patacongo edited a comment on issue #836: audio nxstyle fixes and audio drivers cleanup
Date Tue, 21 Apr 2020 15:16:00 GMT

patacongo edited a comment on issue #836:
URL: https://github.com/apache/incubator-nuttx/pull/836#issuecomment-617243835


   No, your PR really does break the build.  You changed the name of the field ppBuffer in
include/nuttx/audio/audio.h to ppbuffer.  That will break every file that uses audio buffers.
   
   You cannot change audio.h or any other common header file without also changing ALL of
the files that include that header files.  You can either:
   
   1. Back out the changes that you mad to common header files, or,
   2. Change all places where those common header files are included.
   
   The first would be easiest.  The second would be the better contribution to the OS.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message