nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] btashton commented on issue #757: Create release artifacts for release branches
Date Tue, 21 Apr 2020 10:35:42 GMT

btashton commented on issue #757:
URL: https://github.com/apache/incubator-nuttx/pull/757#issuecomment-617097395


   
   > > Also creating the tarballs on the push event means we actually get what made
it into the branch instead of the PR. The way I have it wired up here also means that we insure
that the tag in the apps and the tag in the os are properly built against each other which
would be harder to do if we are doing it off the PR.
   > > 
   > 
   > I notice both apps and nuttx package is generated from the nuttx repo. Is it better
that:
   > 1.The change for nuttx release branch extract the nuttx package
   > 2.The change for apps release branch extract the apps package
   > I am afraid that the apps package is incorrect if the release manager forget merge
apps release branch first.
   > For apps/nuttx synchronization issue, I suppose the patches which enter into the release
branch should seldomly couple between apps and nuttx.
   > 
   
   The way this is setup right now on non tagged commits it will pick the latest from the
the corresponding branch in app.
   
   But importantly if there is a tag it will build that and fail if it cannot find that same
tag in the app. So we know exactly what was built and we have the set of tarballs and signatures
from it. 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message