nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] btashton commented on issue #757: Create release artifacts for release branches
Date Tue, 21 Apr 2020 07:12:59 GMT

btashton commented on issue #757:
URL: https://github.com/apache/incubator-nuttx/pull/757#issuecomment-616998054


   I think we are not talking about the same thing here, so let me write the problem I am
trying to solve.
   
   We are creating release branches `releases/{major}.{minor}`  When these are created I want
to start generating release tarballs off of this.  They need to be versioned `{major}.{minor}.{patch}`.
 To determine the `patch` field I do this
   1. Look for a tag in the format `nuttx-{major}-{minor}` `nuttx-{major}-{minor}-{patch}`
`nuttx-{major}-{minor}-{patch}-RC
   2. If a tag is found already with the major and minor then we use the latest patch field.
   3. If a tag is not found we assume this is the first release of the `{major}.{minor}` so
we create a version string of `{major}.{minor}.{patch}`
   
   Once this version string is created it can be supplied to `version.sh` or the `zipme.sh`
tools.
   
   For users that are working off of a release tag they are likely not on the release branch
so we should not try to use this logic.  They are not creating a potential _new_ release.
 Instead we should do what we are currently doing which is look for the latest  tag (probably
should use git describe instead of git tag, but it does not matter that much).
   
   This is why I explicitly did not change the existing tool and instead wrote a helper version
tool that we can use in the CI process.  I can call the tool something else, but it provides
the functionality that we need to generate the tarball that is required for the release process.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message