nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #757: Create release artifacts for release branches
Date Tue, 21 Apr 2020 06:44:44 GMT

xiaoxiang781216 commented on issue #757:
URL: https://github.com/apache/incubator-nuttx/pull/757#issuecomment-616986400


   > I do _not_ want to match `nuttx-some-fix` and more importantly at some point we will
tag
   > 9.1 and may still backport and only want to match 9.0.# not 9.1.#
   > 
   
   We can get this information by:
   ```
   git branch --show-current
   ```
   
   > `version.sh` is expecting to be passed a full version string `gitversion.sh` can provide
this value to it in the context of a CI run. It really does not make sense outside of a CI
run, but it is complicated enough I did not want to shove it in the yaml file.
   > 
   
   No, version.sh is also used when the user who clone git directly. In this case, .version
is automatically generated in the build process by version.sh. We must ensure that the generated
version number is same regardless which method user is used to get the package.
   
   > ```
   > $ version.sh -v `gitversion.sh 0.1`
   > ```
   > 
   > `version.sh` job is really just setting the config files. The fact that it tries to
guess a version number from git is out of its job in my opinion. Why not drop version being
optional and just:
   > 
   > ```
   > version.sh -v `git describe --match nuttx-[0-9].* --abbrev=0`
   > ```
   
   As I note before, we need consider the user who use repo directly and merge the upstream
regularly after each major release. version.sh is only method here.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message