nuttx-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #757: Create release artifacts for release branches
Date Tue, 21 Apr 2020 05:43:56 GMT

xiaoxiang781216 edited a comment on issue #757:
URL: https://github.com/apache/incubator-nuttx/pull/757#issuecomment-616964963


   > > How about we make zipme.sh major.minor.patch optional:
   > > #834
   > 
   > It is not clear to me how that would help. We want to supply the version string, we
just want to compute it differently.
   > > How about we make zipme.sh major.minor.patch optional:
   > > #834
   > 
   > It is not clear to me how that would help. We want to supply the version string, we
just want to compute it differently.
   
   The version string is just used here:
   ```
   VER_TAG=`git describe --abbrev=0 --match "nuttx-$NUTTX_VERSION" --match "nuttx-$NUTTX_VERSION-*"
--match "nuttx-$NUTTX_VERSION.[0-9]*"  2>/dev/null`
   ```
   I think the below variant should also work too:
   VER_TAG=`git describe --abbrev=0 --match "nuttx-*"  2>/dev/null`
   If not, we still can pass BRANCH_VER=${GITHUB_REF##*/} to zipme.sh and then version.sh.
   It doesn't make sense that we have two scripts(version.sh and gitver.sh) generate the similar
thing, because:
   1.It confuse user which script he/she should use
   2.Developer may forget to update both script at the same time
   If version.sh doesn't work well with release process, it's better to enhance it to handle
the new usage correctly instead creating a new similar script.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message